|
A bug and a few suggestions. 8 Months, 3 Weeks ago
|
Karma: 0
|
First let me thank Igort for this plug-in and making it available to all of us. The idea of this plug-in is good, but I discovered a little bug and I miss a few things. I'm currently using version 1.6 of the plug-in.
The bugs I found:
- A real bug can be found on line 85 in .../plugins/content/smartreszier.php:
| Code: |
if (!$defthumb_medium_width && !$defthumb_medium_heignt)
$defthumb_medium_width = 250;
|
Condition "!$defthumb_medium_heignt" contains a typo and should read "!$defthumb_medium_height".
- There's also a little inconsistency withe the naming of thumbnail files. When specifying only the height or width (instead of both), the names for article thumbnails have a "0" (zero) for the lacking parameter, whereas the names for blog thumbnails don't.
Using the the plug-in for the first time, I found a few things I think could make it even more usable:
- It would be nice to enable pop-up's for blog thumbnails as well.
- Currently it's only possible to choose the display style (old fashioned pop-up or RokBox). I would be nice if it's also possible to disable full image display all together. In combination with my first suggestion, I imagine one would like to enable or disable pop-up's for any of the three thumbnail types individually.
- Currently it's only possible to specify individual image sizes for article thumbnails. Because I have blog pages with varying numbers of columns, I would also like to specify individual sizes for blog thumbnails. So I adjusted the code, but now I can only set individual sizes for blog thumbnails. Preferably I would like to be able to set individual sizes for any of the three thumbnails types.
- The RokBox integration is cool. JCE has pop-up functionality out-of-the box. Being one of the most popular and most used wysiwig editors for Joomla!, maybe it's possible to support JCE style pop-ups as well.
|
|
|
|
|
|
|
...A bug and a few suggestions. 8 Months, 3 Weeks ago
|
Karma: 6
|
|
Thank you very much for remarks.
>It would be nice to enable pop-up's for blog thumbnails as well.
For what? Blog thumbnails links to the full article. It`s more logical.
>Currently it's only possible to choose the display style (old fashioned pop-up or RokBox). I would be nice if it's also possible to disable full image display all together. In combination with my first suggestion, I imagine one would like to enable or disable pop-up's for any of the three thumbnail types individually.
You can disable popups for each thumbnail types to set large thumb size (for example to disable thumbnails for articles You should set "thumb width and hieght for article" to value 9999). I do not know where to place the sizes for individual image size of thumbs in blogs and articles. If you advise to me: where to place the individual sizes not only for article, but also for a blog, I with pleasure realise it.
>Currently it's only possible to specify individual image sizes for article thumbnails. Because I have blog pages with varying numbers of columns, I would also like to specify individual sizes for blog thumbnails. So I adjusted the code, but now I can only set individual sizes for blog thumbnails. Preferably I would like to be able to set individual sizes for any of the three thumbnails types.
You can add a peremetres:
<param name="thumb_width" type="text" default="" label="Thumbnail width for blogs" description="THUMBNAIL WIDTH FOR BLOGS DESC">
</param>
<param name="thumb_height" type="text" default="" label="Thumbnail height for blogs" description="THUMBNAIL HEIGHT FOR BLOGS DESC">
</param>
into the parametres xml file of blog joomla layout:
/components/com_content/views/category/tmpl/blog.xml for categories blog
/components/com_content/views/section/tmpl/blog.xml for sections blog
/components/com_content/views/frontpage/tmpl/default.xml for frontpage blog
It allow to set individual thumbs size for earch blog layout.
Also it is possible to set individual thumbs size for each article, if article has menu item linked
You can add Parametres :
<param name="thumb_medium_width" type="text" default="" label="Default thumbnail width for articles" description="DEFAULT THUMBNAIL WIDTH FOR ARTICLES DESC">
</param>
<param name="thumb_medium_height" type="text" default="" label="Default thumbnail height for articles" description="DEFAULT THUMBNAIL HEIGHT FOR ARTICLES DESC">
</param>
to the article menu item parametres xml file:
/components/com_content/views/article/tmpl/default.xml
There are "non-documented" features and non-tested. If you test these features, I will be very grateful
|
|
Igort
Administrator
Posts: 375
|
|
Last Edit: 2009/11/09 13:17 By Igort.
|
|
|
Re:A bug and a few suggestions. 8 Months, 3 Weeks ago
|
Karma: 0
|
|
Thanks for your swift reply.
For what? Blog thumbnails links to the full article. It`s more logical.
Maybe for your websites that is the case, but for others, like mine, it is not. I prefer to have only article titles and/or "read more" link to the full article, because I think it may confuse visitors when an image sometimes links to an article and sometimes links to a full image pop-up.
You can disable popups for each thumbnail types to set large thumb size (for example to disable thumbnails for articles.....
I assume that by setting large numbers, SmartResizer doesn't create thumbnails and displays the original sized images. But that's not exactly what I mean. I do want the thumbnails to be created, but I just don't want to enable pop-up's on some websites. I appologise for the confusion.
You can add a peremetres: ..... into the parametres xml file of blog joomla layout:
The idea is nice, but it has a major drwaback: they get overwritten when updating Joomla! So I prefer not to touch any core Joomla! files.
I think a solution might be to invent your own extra attributes for the <img> tag. Apart from the formal "width" and "height" you could check for additional "blog_width" and "blog_height" and in a similar way for "other_width" and "other_height".
Another solution is to use a special {smartresize} plug-in tag similar to RokBox. It allows you to define your own set of parameters for the plug-in, without interfering with the attributes standard <img> tag.
|
|
|
|
Last Edit: 2009/11/09 14:36 By pjdevries.
|
|
|
...Re:A bug and a few suggestions. 8 Months, 3 Weeks ago
|
Karma: 6
|
|
I assume that by setting large numbers, SmartResizer doesn't create thumbnails and displays the original sized images. But that's not exactly what I mean. I do want the thumbnails to be created, but I just don't want to enable pop-up's on some websites.
For what? Just insert a small image into article.
I prefer to have only article titles and/or "read more" link to the full article, because I think it may confuse visitors when an image sometimes links to an article and sometimes links to a full image pop-up.
May be I will add the parametre like "Create link to article or full image" for blogs in the next version.
I think a solution might be to invent your own extra attributes for the <img> tag. Apart from the formal "width" and "height" you could check for additional "blog_width" and "blog_height" and in a similar way for "other_width" and "other_height".
Another solution is to use a special {smartresize} plug-in tag similar to RokBox. It allows you to define your own set of parameters for the plug-in, without interfering with the attributes standard <img> tag.
I think It will be difficult to set the blog thumb size for each image manually in html code editor. If use this custom image proprties: "other_width" and "other_height" , then it will be non-valid html code. Also the blog can have a multicolumn layout. The first articles is shown for 1 column, the next articles in 2 o more columns. And position of articles is changes after the adding new article into category. So the thumbnails size must be variable for 1 column position and several column position.
I have an idea to create custom blog layout for front page, category blog, and section blog: There are three or four blocks in this blog layout. There is different number of columns In each block. And each block have its own thumbnail size. Somthing like this.
|
|
Igort
Administrator
Posts: 375
|
|
Last Edit: 2009/11/09 21:38 By Igort.
|
|
|
Re:A bug and a few suggestions. 8 Months, 3 Weeks ago
|
Karma: 0
|
|
For what? Just insert a small image into article.
But isn't that what smartresizer is for? To scale down images to proper sizes for blog, artyicle and other content types? The only think I would like to see, is the ability to disable pop-up's.
If use this custom image proprties: "other_width" and "other_height" , then it will be non-valid html code.
I guess you're right. Although nothing will break, it probably isn't the smartest and definitly not the proper thing to do.
I have an idea to create custom blog layout for front page, category blog, and section blog: There are three or four blocks in this blog layout. There is different number of columns In each block. And each block have its own thumbnail size. Somthing like this.
I'm not sure if I understand exactly what you're implying, but if you mean what I think you do, it would be a great enhancement!
|
|
|
|
|
|
|